Repository navigation
feat(select): open panel as dialog on smaller screens - #5313
Merged
Merged
Conversation
Supamiu
added
🔖✨ Feature
Supamiu
changed the title
|
🚀 Storybook preview deployed: https://pub-dc6d99acd6874e2aaff6219dd8a13ae2.r2.dev/PR-5313/index.html |
c-3po
Bot
added
the
🔨 Technical
Supamiu
marked this pull request as ready for review
September 10, 2026 13:20
JeSuisCharlie1
previously approved these changes
Sep 14, 2026
Supamiu
commented
Sep 17, 2026
Comment on lines
+74
to
+75
| style.setProperty('--components-dialog-visibleViewportHeight', `${viewport.height}px`); | ||
| style.setProperty('--components-dialog-visibleViewportBottomOffset', `${window.innerHeight - viewport.height - viewport.offsetTop}px`); |
Contributor
Author
There was a problem hiding this comment.
Wouldn't this affect existing dialogs too? Say we have a select inside a dialog, because it's a generic var, I assume it's used by every dialog.
Contributor
There was a problem hiding this comment.
I'm pushing one more commit.
Supamiu
force-pushed
the
feat/small-display-select
branch
from
October 5, 2026 08:33
7a83c61 to
65f9453
Compare
…point Below the S breakpoint the select panel opens as a modal bottom sheet carrying its own search field, and the field itself becomes a plain button trigger so mobile browsers stop raising the software keyboard on a control the sheet is about to cover. Rebased onto release/22.1: the panel markup is the one of the listbox refactor, and the trigger now labels itself through the form field `luInputLabelledBy` API instead of writing `aria-labelledby` itself. The form field keeps the branch's `removeInput` and self-label tracking, which the swap between button and text input needs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jeremie-lucca
force-pushed
the
feat/small-display-select
branch
from
October 5, 2026 16:13
65f9453 to
3b9b49f
Compare
JeSuisCharlie1
previously approved these changes
Oct 6, 2026
vvalentin-lucca
approved these changes
Oct 6, 2026
jeremie-lucca
approved these changes
Oct 6, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Select now opens in a dialog when display it too small.
Partially made with Claude, especially for the base structure, as it's basically "reuse what I did for filter pill but on a dialog".
I opened a draft so we can check for conflicts and have a public storybook to play with
Optionally, technical or more in-depth description for reviewers.
Keep an empty line under your text, as well as the 5 lines that follow it.